modify roll test=develop #25321
Merged
modify roll test=develop #25321
+70 −47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
jzhang533 reviewed Jul 8, 2020
| | ||
| def roll(input, shifts, dims=None): | ||
| def roll(input, shifts, axis=None, name=None): | ||
| """ |
There was a problem hiding this comment.
it should be : paddle.tensor.roll(x, shifts, axis=None, name=None)
according to the latest argument convention.
jzhang533 reviewed Jul 8, 2020
python/paddle/tensor/manipulation.py Outdated
| shifts (int|list|tuple): The number of places by which the elements | ||
| of the `input` tensor are shifted. | ||
| dims (int|list|tuple|None): Dimentions along which to roll. | ||
| axis (int|list|tuple|None): Dimentions along which to roll. |
There was a problem hiding this comment.
Dimensions -> axis
上面的简介部分：``Roll the input tensor along ...'' 需要换一种说法, character level copy是不可以的。
示例代码中用paddle.enable_imperative()开启动态图模式，方便未来默认动态图的时候统一调整示例代码。
| "Attr(dims[%d]) is out of range, It's expected " | ||
| "to be in range of [-%d, %d]. But received Attr(dims[%d]) = %d.", | ||
| "Attr(axis[%d]) is out of range, It's expected " | ||
| "to be in range of [-%d, %d]. But received Attr(axis[%d]) = %d.", |
There was a problem hiding this comment.
Python端也增加对axis范围的检查，防止打印出来call stack。
liym27 approved these changes Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
OthersPR changes
APIsDescribe
According to paddle 2.0 standard
1, change attr name 'dim' to 'axis'
2, change api input name 'input' to 'x'
3, add check axis value in python code and related ut.
4,change example code to imperative mode