Fix the bug that Input(Offsets) and attr(offsets) cannot be set at the same time. #24975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
| ✅ This PR's description meets the template requirements! |
sandyhouse requested review from gavin1332 and zhangting2020 and removed request for gavin1332 
zhangting2020 approved these changes Jul 30, 2020
Contributor
zhangting2020 left a comment
zhangting2020 left a comment There was a problem hiding this comment.
LGTM. 因为参数要支持Tensor，但是同时需要在compile time推断出shape，因此就必须同时用Offsets(Input)和attr offsets. attr offsets用于shape推断。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Fix the bug that Input(Offsets) and attr(offsets) cannot be set at the same time.
The python side set them both (as the following figure shows), and Input(Offsets) has a high priority， thus we can remove the ENFORCE_XX statement in the source codes.