import 3rd party target in CMake #2343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gangliao commented Jun 1, 2017
| | ||
| if(NOT APPLE) | ||
| find_package(Threads REQUIRED) | ||
| link_libraries(${CMAKE_THREAD_LIBS_INIT}) |
There was a problem hiding this comment.
default any target will link thread
gangliao commented Jun 1, 2017
| @@ -1,5 +1,5 @@ | |||
| cc_library(place SRCS place.cc) | |||
| cc_test(place_test SRCS place_test.cc DEPS place) | |||
| cc_test(place_test SRCS place_test.cc DEPS place glog gflags) | |||
There was a problem hiding this comment.
glog gflags is used to test this feature
There was a problem hiding this comment.
I think this is the right way -- to require the specification of glog and gflags explicitly -- and could be the default way.
wangkuiyi approved these changes Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #2327