Skip to content

Conversation

@Yancey0623
Copy link
Contributor

@Yancey0623 Yancey0623 commented May 12, 2017

here may better to view.

Related issue: #2019

Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!另外,为何关了上一个PR(#1770 )而新开了这个?要是一直在同一个PR讨论/修改,大家会容易follow up一点。

Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yancey0623
Copy link
Contributor Author

@helinwang 主要是因为上个PR的comments太多了,打开页面会加载很长时间。

@Yancey0623 Yancey0623 merged commit ae647bf into PaddlePaddle:develop May 13, 2017
@Yancey0623 Yancey0623 deleted the submit-job-doc branch May 13, 2017 02:55
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants