Add list type of feeding #1766
Merged
Add list type of feeding #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wangkuiyi requested changes Apr 10, 2017
| input_types = [] | ||
| if feeding is None: | ||
| feeding = default_feeding_map(data_types) | ||
| elif isinstance(feeding, collections.Sequence): |
There was a problem hiding this comment.
As here we allow feeding to be a new type -- Sequence, we should update/add the example in above comment?
wangkuiyi requested changes Apr 12, 2017
| data_types = [('image', paddle.data_type.dense_vector(784)), | ||
| ('label', paddle.data_type.integer_value(10))] | ||
| feeding = ['image', 'label'] | ||
| feeder = DataFeeder(data_types=data_types, feeding=feeding) |
There was a problem hiding this comment.
这里我没太明白—— data_types。
reader返回的是Python native data types，比如tuple，而不是 paddle.data_type.XXX 对吧？所以我以为 paddle.data_type.XXX 应该是layer的属性，而不是DataFeeder的属性。
There was a problem hiding this comment.
是的，这个data_type实际上是从layer拿过来的。这个类其实是paddle的一个内部类，不是用户的接口。
There was a problem hiding this comment.
和 @reyoung 沟通，这段example code并不是用户写的，而是我们的paddle/v2/trainer.py里的代码。其中
data_types = [('image', paddle.data_type.dense_vector(784)), ('label', paddle.data_type.integer_value(10))] 实际上应该是
data_types = enumerate_data_types_of_data_layers(topology) wangkuiyi approved these changes Apr 12, 2017
| data_types = [('image', paddle.data_type.dense_vector(784)), | ||
| ('label', paddle.data_type.integer_value(10))] | ||
| feeding = ['image', 'label'] | ||
| feeder = DataFeeder(data_types=data_types, feeding=feeding) |
There was a problem hiding this comment.
和 @reyoung 沟通，这段example code并不是用户写的，而是我们的paddle/v2/trainer.py里的代码。其中
data_types = [('image', paddle.data_type.dense_vector(784)), ('label', paddle.data_type.integer_value(10))] 实际上应该是
data_types = enumerate_data_types_of_data_layers(topology) Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
paddle.v2的feeding参数，原来只能接受一个map，key为data_layer的名字，value为reader里面的yield元素的index。
增加feeding可以传递一个list的情况。也就是直接按照reader里面的index传递data_layer的名字。不过这样不支持某一个元素传递两遍或者不使用的情况。
但是，增加这个功能，可以简化80%的使用场景。