Fix compiler warning & speed up compile stage. #1197
Conversation
Extract FunctionBase into a seperate header.
| CHECK_EQ(shape_.ndims(), (size_t)2); | ||
| CHECK_EQ(row_.shape().ndims(), (size_t)1); | ||
| CHECK_EQ(col_.shape().ndims(), (size_t)1); | ||
| CHECK_EQ(shape_.ndims(), 2UL); |
There was a problem hiding this comment.
It is simpler to use a 'U' or 'UL' suffix.
| #include <memory> | ||
| #include "ModelConfig.pb.h" | ||
| #include "paddle/function/Function.h" | ||
| #include "paddle/function/FunctionBase.h" |
There was a problem hiding this comment.
Make Layer.h depend on FunctionBase.h.
It could speed up compiling time very much, and it makes us not to recompile the whole Paddle when we change something in Function library.
There was a problem hiding this comment.
Layer.h还是需要知道完整的BufferArgs类型的；Function的Prepare arguments阶段是将Layer的参数Argument类型，转换成Function的参数BufferArg类型，这个对于很多Layer的实现是一样的，后续会考虑在class Layer里面实现。
编译耗时的问题可能来自于，当前BufferArg的一些函数的实现是在类声明里面的，这些可以移入cpp里面。
There was a problem hiding this comment.
好，那我先close了。。其他的fix回头顺手改一下吧 :)
| CHECK_EQ(shape_.ndims(), (size_t)2); | ||
| CHECK_EQ(row_.shape().ndims(), (size_t)1); | ||
| CHECK_EQ(col_.shape().ndims(), (size_t)1); | ||
| CHECK_EQ(shape_.ndims(), 2UL); |
| #include <memory> | ||
| #include "ModelConfig.pb.h" | ||
| #include "paddle/function/Function.h" | ||
| #include "paddle/function/FunctionBase.h" |
There was a problem hiding this comment.
Layer.h还是需要知道完整的BufferArgs类型的；Function的Prepare arguments阶段是将Layer的参数Argument类型，转换成Function的参数BufferArg类型，这个对于很多Layer的实现是一样的，后续会考虑在class Layer里面实现。
编译耗时的问题可能来自于，当前BufferArg的一些函数的实现是在类声明里面的，这些可以移入cpp里面。
* Refine create_array op api doc. test=develop Signed-off-by: zhaoyuchen <zhaoyuchen01@baidu.com> * Refine create_array api doc test=develop Signed-off-by: zhaoyuchen <zhaoyuchen01@baidu.com>
* Add missing `#include <cstdio>` * move to non nvrtc part --------- Co-authored-by: Haicheng Wu <haichengw@nvidia.com>
2 participants
Extract FunctionBase into a seperate header.