Add python wrapper for gather op. #11033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
baiyfbupt reviewed May 31, 2018
python/paddle/fluid/layers/nn.py Outdated
| Args: | ||
| input (Variable): The source input with rank>1. | ||
| index (Variable): The index input with rang=1. |
qingqing01 reviewed Jun 1, 2018
python/paddle/fluid/layers/nn.py Outdated
| **Gather Operator** | ||
| Out is obtained by gathering entries of the outer-most dimension | ||
| of X indexed by Index and concatenate them together. |
There was a problem hiding this comment.
- Out -> Output
Index -> `index` python/paddle/fluid/layers/nn.py Outdated
| .. code-block:: text | ||
| * Case 1: |
python/paddle/fluid/layers/nn.py Outdated
| index (Variable): The index input with rang=1. | ||
| Returns: | ||
| output (Variable): The output is a tensor with the same shape as input. |
kuke reviewed Jun 1, 2018
python/paddle/fluid/layers/nn.py Outdated
| | ||
| def gather(input, index): | ||
| """ | ||
| **Gather Operator** |
There was a problem hiding this comment.
In Python API, there should not be any operator.
python/paddle/fluid/layers/nn.py Outdated
| [5, 6]] | ||
| Args: | ||
| input (Variable): The source input with rank>1. |
There was a problem hiding this comment.
gather_op should work even if rank == 1, please consider to modify it.
There was a problem hiding this comment.
Thx. The op support rank==1 already. I add a unitest for rank==1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add python wrapper for gather op.