-   Notifications  You must be signed in to change notification settings 
- Fork 5.9k
Enhanced is_empty_op for our seq2seq model #10704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
   Merged  
     Merged  
 Changes from all commits
 Commits 
  Show all changes 
  6 commits   Select commit Hold shift + click to select a range 
  File filter
Filter by extension
Conversations
 Failed to load comments.  
    Loading  
 Jump to
  Jump to file  
  Failed to load files.  
    Loading  
 Diff view
Diff view
There are no files selected for viewing
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
        This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. | ||
|  | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|  | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|  | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|  | ||
| #pragma once | ||
| #include "paddle/fluid/framework/op_registry.h" | ||
| #include "paddle/fluid/framework/operator.h" | ||
|  | ||
| namespace paddle { | ||
| namespace operators { | ||
|  | ||
| template <typename DeviceContext, typename T> | ||
| class IsEmptyOpKernel : public framework::OpKernel<T> { | ||
| public: | ||
| void Compute(const framework::ExecutionContext& context) const override { | ||
| // get input | ||
| auto* input_tensor = context.Input<framework::LoDTensor>("X"); | ||
| // get output | ||
| auto* output_tensor = context.Output<framework::LoDTensor>("Out"); | ||
|  | ||
| output_tensor->mutable_data<bool>(platform::CPUPlace())[0] = | ||
| framework::product(input_tensor->dims()) == 0; | ||
| } | ||
| }; | ||
|  | ||
| } // namespace operators | ||
| } // namespace paddle | 
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -49,6 +49,7 @@ | |
| 'reorder_lod_tensor_by_rank', | ||
| 'ParallelDo', | ||
| 'Print', | ||
| 'is_empty', | ||
| ] | ||
|  | ||
|  | ||
|  | @@ -1562,3 +1563,40 @@ def reorder_lod_tensor_by_rank(x, rank_table): | |
| 'RankTable': [rank_table]}, | ||
| outputs={'Out': [out]}) | ||
| return out | ||
|  | ||
|  | ||
| def is_empty(x, cond=None, **ignored): | ||
| """ | ||
| **Is Empty** | ||
|  | ||
| This layer returns the truth value of whether the variable is empty. | ||
|  | ||
| Args: | ||
| x(Variable): Operand of *is_empty* | ||
| cond(Variable|None): Optional output variable to store the result | ||
| of *is_empty* | ||
|  | ||
| Returns: | ||
| Variable: The tensor variable storing the output of *is_empty*. | ||
|  | ||
| Raises: | ||
| TypeError: If input cond is not a variable, or cond's dtype is | ||
| not bool | ||
|  | ||
| Examples: | ||
| .. code-block:: python | ||
|  | ||
| less = fluid.layers.is_empty(x=input) | ||
| """ | ||
| helper = LayerHelper("is_empty", **locals()) | ||
| if cond is None: | ||
| cond = helper.create_tmp_variable(dtype='bool') | ||
| cond.stop_gradient = True | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please check the data type in  There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. | ||
| elif not isinstance(cond, Variable): | ||
| raise TypeError("cond takes a variable") | ||
| elif cond.dtype != 'bool': | ||
| raise TypeError("The data type of cond must be bool") | ||
|  | ||
| helper.append_op( | ||
| type='is_empty', inputs={'X': [x]}, outputs={'Out': [cond]}) | ||
| return cond | ||
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
      Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this section, we can add
Raisessection. Please refer to https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/fluid/layers/nn.py#L149There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.