Change default split minimize value to speed up transport data to pserver. #10635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
gongweibao commented May 14, 2018
gongweibao commented - Add some python docstring.
- According to Performance comparison of some frameworks. #10120 , Change default split minimize value to speed up transport data to pserver.
typhoonzero reviewed May 14, 2018
| We need to have a minimal block size so that the calculations in | ||
| the parameter server side can gain better performance. By default | ||
| minimum block size is 1024. |
There was a problem hiding this comment.
By default, the minimum block size is 16k elements (maybe 16bit or 32bit or 64bit).
typhoonzero approved these changes May 15, 2018
| def _append_split_op(self, program, gradblocks): | ||
| # Split variables that need to be split and append respective ops | ||
| """ | ||
| Split variables that need to be split and append respective ops |
There was a problem hiding this comment.
Split variables with the size larger than the minimum size, and append split_byref_op and concat_op for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.