Skip to content

Conversation

@tianbingsz
Copy link
Contributor

@tianbingsz tianbingsz commented Jan 3, 2017

This PR is to simplify unit test by adding paddle_test_util static lib.

  1. For example, in add paddle functions for Matrix ContextProjection APIs #1009,
    add_unittest(ContextProjectionOpTest
    ContextProjectionOpTest.cpp
    ../gserver/tests/TestUtil.cpp)
    could be simplified as add_simple_unittest(ContextProjectionOpTest).

  2. In gserver/tests/CMakeLists.txt, we could remove the dependency of TestUtil.cpp in many unit tests.

Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞!

一个建议:testing/TestUtil.{h,cpp} 是不是可以叫做 testing/Util.{h,cpp} ? 因为我们 #include 的时候反正要写全路径名,而目录名里已经有 testing 这个词了。
@wangkuiyi, 多谢review,主要看到里面还有一个TestMain.cpp,我先merge一下,如果需要再改多话,我再更新一下。

@tianbingsz tianbingsz merged commit 0057c80 into PaddlePaddle:develop Jan 6, 2017
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants