add python version evaluate function #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wangkuiyi requested changes Dec 29, 2016
demo/recommendation/evaluate.py Outdated
| import math | ||
| | ||
| | ||
| def get_best_pass(filename): |
There was a problem hiding this comment.
filname ==> log_filename 这样更具体一些，让人知道这个函数的输入是什么
https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming
wangkuiyi approved these changes Jan 1, 2017
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #1035
As evaluate.sh don't work in Mac, I add a python version evaluate function. The output is the same as evaluete.sh