Skip to content

Conversation

@wanglei828
Copy link
Contributor

No description provided.

@wanglei828 wanglei828 force-pushed the fixtravis branch 2 times, most recently from 463323f to 98147ba Compare April 27, 2018 00:22
Copy link
Contributor

@helinwang helinwang Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe RelWithDebInfo is better?

Never mind, it's for doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add linkchecker to check websites for broken links:

# check websites for broken links
linkchecker doc/v2/en/html/index.html
linkchecker doc/v2/cn/html/index.html
linkchecker doc/v2/api/en/html/index.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the linkcheck.

helinwang
helinwang previously approved these changes Apr 27, 2018
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wanglei828 wanglei828 merged commit 95d2651 into PaddlePaddle:develop May 1, 2018
@wanglei828 wanglei828 deleted the fixtravis branch May 1, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants