PoC for customizing comment thread #151
Conversation
miguelcalderon left a comment
miguelcalderon left a comment There was a problem hiding this comment.
Works great! Just shared some comments for your consideration.
I'm getting a Node update warning from Vite. Maybe we can bump the NodeJS version in .tool-versions a bit up, I think 22.12.0?
web/ui-customization/package.json Outdated
| "@baseline-ui/core": "^0.45.8", | ||
| "@baseline-ui/icons": "^0.45.8", | ||
| "@baseline-ui/tokens": "^0.45.8", | ||
| "@nutrient-sdk/viewer": "1.9.0-nightly.20251106", |
There was a problem hiding this comment.
Can't this wait until 1.9.0? :D
There was a problem hiding this comment.
Yup, definitely. Waiting for 1.9.0 to go out first.
| }); | ||
| } | ||
| | ||
| cleanup = () => { |
There was a problem hiding this comment.
By the time we get here, the initial cleanup function has already been returned. I don't think this would ever be called, would it?
There was a problem hiding this comment.
I checked by unmounting App with a timer and it's being called. By the time cleanup of the effect runs the cleanup variable is updated to the function which runs unload on NutrientViewer.
Details
Adds a demo for building comments functionality using the UI customization (slots) API. Uses React and BaselineUI.
Note for review:
App.tsxandCommentThread.tsxDemo
2025-11-07.at.17.30.06.-.Tan.Tern.mp4
Todo