Skip to content

Conversation

@MathiasReker
Copy link

Proposed changes

This PR improves the coding standards.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

Further comments

~

@MathiasReker MathiasReker deleted the review branch February 24, 2022 21:44
@Geolim4
Copy link
Member

Geolim4 commented Feb 24, 2022

Hello,

Multiple points:

  • Yoda conditions are not part of PSR-12 and I don't like them personally because it increase the cognitive load.
  • PHP Core functions must remain prefixed with \ because of small opcache optimization benefit
  • bin/stubs should not be touched as it is used for phpmd/phpstan quality tools
  • mb_ replacement functions could introduce BC break or undersired behaviors, so I won't take any risks on it
  • Some lines are too long

It's kind but for now the code style has been carefully studied and will stay as is.

Thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants