Skip to content

Conversation

@jonnsn
Copy link
Contributor

@jonnsn jonnsn commented Jul 4, 2014

Allow the creation of bookmarks and hyperlinks to these in Word2007

@Progi1984
Copy link
Member

@jonnsn It misses some sample (Samples directory) and document (Docs directory)

If you know PHPUnit, it misses some unit tests (Tests directory). And you have broken some units tests : https://travis-ci.org/PHPOffice/PHPWord/jobs/29137810#L325

Else good job :)

@jonnsn
Copy link
Contributor Author

jonnsn commented Jul 4, 2014

As far as I can see the build fails because of the Tests in PHPOffice/PHPWord/tests. Sadly I actually do not really know where and what I have to do/add to fix it... I will try to dig into it, but maybe someone could help me out faster?

jonnsn added 2 commits July 4, 2014 15:31
fix undefined Index
added documentation for bookmark-Element.
@jonnsn
Copy link
Contributor Author

jonnsn commented Jul 4, 2014

@Progi1984 Thanks - I added sample and docs.
And I think I got the point now regarding the unit tests...

@Progi1984
Copy link
Member

Just an error :

FILE: /home/travis/build/PHPOffice/PHPWord/src/PhpWord/PhpWord.php -------------------------------------------------------------------------------- FOUND 1 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 142 | ERROR | No space found after comma in function call -------------------------------------------------------------------------------- 
@jonnsn
Copy link
Contributor Author

jonnsn commented Jul 4, 2014

All fixed :)

@Progi1984 Progi1984 added this to the 0.12.0 milestone Jul 4, 2014
@Progi1984
Copy link
Member

Good job.

@ivanlanin Ok for you ?

@Progi1984 Progi1984 modified the milestone: 0.12.0 Jul 4, 2014
@ivanlanin
Copy link
Contributor

Thanks for the enhancement. Sorry for the late response. I was out of town last week. The enhancement reused existing structure and enrich PHPWord's feature. Please go ahead with the merge.

@Progi1984
Copy link
Member

I'll merge it :)

Progi1984 added a commit that referenced this pull request Jul 6, 2014
@Progi1984 Progi1984 merged commit a23ff4d into PHPOffice:develop Jul 6, 2014
@Progi1984 Progi1984 self-assigned this Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment