Skip to content

Conversation

@gimler
Copy link
Contributor

@gimler gimler commented Dec 7, 2023

Description

Replace line breaks with XML representation to use multi line values with TemplateProcessor.

Fixes #268 #2323 #2486

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • [ ] I have updated the documentation to describe the changes
@coveralls
Copy link

coveralls commented Dec 7, 2023

Coverage Status

coverage: 97.213% (+0.001%) from 97.212%
when pulling a056914 on gimler:feature/mulitline
into 050e74e on PHPOffice:master.

@gimler
Copy link
Contributor Author

gimler commented Dec 21, 2023

@Progi1984 can you take a look please?

Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gimler Great fix. Could you update the changelog 2.0.0.md, please ?

@gimler gimler force-pushed the feature/mulitline branch 2 times, most recently from bd089c4 to b7d2238 Compare January 7, 2024 18:17
@gimler gimler force-pushed the feature/mulitline branch from b7d2238 to a056914 Compare January 7, 2024 18:52
@gimler
Copy link
Contributor Author

gimler commented Jan 7, 2024

@Progi1984 i have updated the changelog.

@Progi1984 Progi1984 added this to the 2.0.0 milestone Jan 7, 2024
@Progi1984 Progi1984 merged commit b54465d into PHPOffice:master Jan 7, 2024
@Progi1984
Copy link
Member

Thanks @gimler for your contribution.

@gimler gimler deleted the feature/mulitline branch January 8, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants