Update Footnote.php #2347
Open
Update Footnote.php #2347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
缺少a的结束标签
kernusr reviewed Dec 6, 2022
| $noteId = count($parentWriter->getNotes()) + 1; | ||
| $noteMark = $this->noteType . '-' . $this->element->getRelationId(); | ||
| $content = "<a name=\"{$noteMark}\"><a href=\"#note-{$noteId}\" class=\"NoteRef\"><sup>{$noteId}</sup></a>"; | ||
| $content = "<a name=\"{$noteMark}\"><a href=\"#note-{$noteId}\" class=\"NoteRef\"><sup>{$noteId}</sup></a></a>"; |
Contributor
There was a problem hiding this comment.
The HTML5 standard does not allow nested tags.
It needs to be rewritten like this
$content = "<a name=\"{$noteMark}\"></a><a href=\"#note-{$noteId}\" class=\"NoteRef\"><sup>{$noteId}</sup></a>";
Progi1984 reviewed Jan 8, 2023
| $noteId = count($parentWriter->getNotes()) + 1; | ||
| $noteMark = $this->noteType . '-' . $this->element->getRelationId(); | ||
| $content = "<a name=\"{$noteMark}\"><a href=\"#note-{$noteId}\" class=\"NoteRef\"><sup>{$noteId}</sup></a>"; | ||
| $content = "<a name=\"{$noteMark}\"><a href=\"#note-{$noteId}\" class=\"NoteRef\"><sup>{$noteId}</sup></a></a>"; |
Member
There was a problem hiding this comment.
Suggested change
| $content = "<a name=\"{$noteMark}\"><a href=\"#note-{$noteId}\" class=\"NoteRef\"><sup>{$noteId}</sup></a></a>"; | |
| $content = "<a name=\"{$noteMark}\" href=\"#note-{$noteId}\" class=\"NoteRef\"><sup>{$noteId}</sup></a>"; |
@heiseeyong May be with this fix, it should be better ?
Ping @kernusr
Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
缺少a的结束标签
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported