AbstractPatternSniff::__construct(): remove the $ignoreComments property #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PHPCS deprecated the `$ignoreComments` parameter of the `AbstractPatternSniff::__construct()` sniff in version 1.4.0. > - AbstractPatternSniff now sets the ignoreComments option using a public var rather than through the constructor > - This allows the setting to be overwritten in ruleset.xml files > - Old method remains for backwards compatibility Time to remove this dead code. Related to 6
fredden approved these changes Apr 14, 2025
greg0ire approved these changes Apr 14, 2025
jrfnl deleted the phpcs-4.0/feature/6-abstractpatternsniff-remove-deprecated-param branch 18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
PHPCS deprecated the
$ignoreCommentsparameter of theAbstractPatternSniff::__construct()sniff in version 1.4.0.Time to remove this dead code.
Related to #6
Suggested changelog entry
Removed: The
$ignoreCommentsparameter for theAbstractPatternSniff::__construct()method.