PHP 8.2 | Generic/[Lower|Upper]CaseConstant: bug fix - ignore DNF property types #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…perty types The `Generic.PHP.LowerCaseConstant` sniff is supposed to flag uppercase use of the `true`/`false`/null` constants and its sister-sniff `UpperCaseConstant` flags the lowercase variants. Both sniffs, however, are supposed to **_ignore_** the use of these keywords in type declarations - which may have their own rules. Some previous PRs already fixed most of the issues with that (119, 330), but it looks like DNF-types in property declarations were not yet handled correctly. Fixed now. Includes tests.
jrfnl deleted the feature/generic-lower-uppercaseconstants-support-dnf-types branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
The
Generic.PHP.LowerCaseConstantsniff is supposed to flag uppercase use of thetrue/false/nullconstants and its sister-sniffUpperCaseConstantflags the lowercase variants. Both sniffs, however, are supposed to ignore the use of these keywords in type declarations - which may have their own rules.Some previous PRs already fixed most of the issues with that (#119, #330), but it looks like DNF-types in property declarations were not yet handled correctly.
Fixed now.
Includes tests.
Suggested changelog entry
Generic.PHP.LowerCaseConstant and Generic.PHP.UpperCaseConstant will now correctly ignore DNF types for properties.