Skip to content

Conversation

rodrigoprimo
Copy link
Contributor

Description

This PR improves the RecurseScopeMapDefaultKeywordConditionsTest::testSwitchDefault() test method by replacing offsets with markers. This helps stabilize the tests.

This PR is the last one in a series of PRs to improve the RecurseScopeMapDefaultKeywordConditionsTest tests. The other PRs in this series are #813, #850, #870, and #902.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
Using markers instead of offsets help stabilize the tests.
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigoprimo !

@jrfnl jrfnl added this to the 3.12.2 milestone Apr 7, 2025
@jrfnl jrfnl merged commit b2a9ea4 into PHPCSStandards:master Apr 8, 2025
118 checks passed
@jrfnl jrfnl deleted the use-markers-for-test-switch-default branch April 8, 2025 03:24
jrfnl pushed a commit that referenced this pull request Apr 8, 2025
* Tests/Tokenizer: use markers for the `testSwitchDefault()` test Using markers instead of offsets help stabilize the tests. * Fix: keys in sub-arrays in data provider methods should match the parameter names of the test method * Fix: marker passed to the error message of two assertions * Include all possible token types when looking for the condition stop token * Move list of condition stop tokens to a class property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment