Skip to content

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Mar 31, 2024

Description

Squiz/ForLoopDeclaration: rename test case file

... in anticipation of adding addition test case files.

Squiz/ForLoopDeclaration: move parse error test to its own file

Squiz/ForLoopDeclaration: bug fix - prevent sniff erroring out

... on an "Undefined array key "parenthesis_closer" " notice during live coding.

Includes unit test.

Suggested changelog entry

Squiz.ControlStructures.ForLoopDeclaration: prevent a potential "undefined array key" notice during live coding

@jrfnl jrfnl added this to the 3.9.2 milestone Mar 31, 2024
@jrfnl jrfnl changed the title Feature/squiz forloopdeclaration prevent php notice Squiz/ForLoopDeclaration: bug fix - prevent sniff erroring out Mar 31, 2024
Copy link
Contributor

@rodrigoprimo rodrigoprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left one inline question about a detail for us to discuss.

@jrfnl jrfnl force-pushed the feature/squiz-forloopdeclaration-prevent-php-notice branch from 1fbd83d to afc3365 Compare April 2, 2024 21:48
@jrfnl jrfnl force-pushed the feature/squiz-forloopdeclaration-prevent-php-notice branch from afc3365 to 674701a Compare April 6, 2024 15:43
@jrfnl
Copy link
Member Author

jrfnl commented Apr 6, 2024

Rebased without changes. Merging once the build passes.

@jrfnl
Copy link
Member Author

jrfnl commented Apr 6, 2024

The build failure is unrelated to this PR. PR #436 should fix this. I will rebase again once that one has been merged.

jrfnl added 3 commits April 6, 2024 19:40
... in anticipation of adding addition test case files.
... on an _"Undefined array key "parenthesis_closer" "_ notice during live coding. Includes unit test.
@jrfnl jrfnl force-pushed the feature/squiz-forloopdeclaration-prevent-php-notice branch from 674701a to 9634005 Compare April 6, 2024 17:40
@jrfnl jrfnl merged commit b131294 into master Apr 6, 2024
@jrfnl jrfnl deleted the feature/squiz-forloopdeclaration-prevent-php-notice branch April 6, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment