PSR12.Files.DeclareStatement
- bow out when parse error detected #335
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This began as part of #289.
When a parse error is present, the
PSR12.Files.DeclareStatement
sniff was incorrectly performing an auto-fix. (That change was then conflicting withPSR12.Operators.OperatorSpacing
- #289 includes improvements to that sniff to avoid the conflict from the other end too.) This pull request adds some defensive coding to identify and bow out when a particular parse error is detected. Further defensive coding can be added in future to detect other errors here. (@jrfnl has expressed intention to rewrite this sniff, so I'm not addressing all parse error cases right now.)Suggested changelog entry
PSR12.Files.DeclareStatement
- bow out when parse error detectedTypes of changes
PR checklist