Skip to content

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 5, 2023

Description

Recreation of upstream PR squizlabs/PHP_CodeSniffer#3667:

Minor defensive coding and documentation improvements + an additional unit test.

The original PR was bigger and contained a bug fix, but was fixed in parallel via another commit.

Fixed by commit squizlabs/PHP_CodeSniffer@9445108 in response to issue squizlabs/PHP_CodeSniffer#3666, though this PR still contains some minimal differences (defensive coding, comment + minor difference in the fix) which may be worth having a look at.

Suggested changelog entry

N/A

Minor defensive coding and documentation improvements + an additional unit test.
@jrfnl jrfnl added this to the 3.8.0 milestone Dec 5, 2023
@jrfnl jrfnl merged commit 3c80ec8 into master Dec 5, 2023
@jrfnl jrfnl deleted the feature/pear-functioncallsignature-minor-tweaks branch December 5, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment