Skip to content

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 6, 2025

Description

Prevent false negatives for the "incorrect space after keyword" error.

Includes tests.

Suggested changelog entry

  • Added support for PHP 8.4 asymmetric visibility modifiers to the following sniffs:
    • Squiz.WhiteSpace.ScopeKeywordSpacing

Related issues/external references

Follow up on #851
Follow up on #1116

Related to #734

@jrfnl jrfnl added this to the 3.13.1 milestone Jun 6, 2025
@jrfnl jrfnl mentioned this pull request Jun 6, 2025
47 tasks
Base automatically changed from php-8.4/feature/file-methods-support-asym-visibility to master June 9, 2025 01:45
@jrfnl jrfnl marked this pull request as ready for review June 9, 2025 01:55
…bility Prevent false negatives for the "incorrect space after keyword" error. Includes tests.
@jrfnl jrfnl force-pushed the php-8.4/feature/squiz-scopekeywordspacing-support-asym-visibility branch from c463fc0 to 0f2ba2e Compare June 9, 2025 03:57
@jrfnl
Copy link
Member Author

jrfnl commented Jun 9, 2025

Rebased without changes to get a proper build.

@jrfnl jrfnl merged commit 572c70a into master Jun 9, 2025
62 checks passed
@jrfnl jrfnl deleted the php-8.4/feature/squiz-scopekeywordspacing-support-asym-visibility branch June 9, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment