Runner: error message if no files were checked during a run #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
... and exit with a non-zero exit code. Fixes squizlabs/PHP_CodeSniffer 1595 Note: the tests only cover the new error message and not the situation where this message would _not_ be shown (outside the scope of this change). Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
jrfnl force-pushed the phpcs-4.0/feature/sq-1595-display-error-on-no-files-checked branch from 829c6d4 to 14cc840 Compare jrfnl deleted the phpcs-4.0/feature/sq-1595-display-error-on-no-files-checked branch 4 tasks
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Show error message if no files were checked during a run and exit with a non-zero exit code.
Note: the tests only cover the new error message and not the situation where this message would not be shown (outside the scope of this change).
Suggested changelog entry
Added:
An error message is now displayed if no files were checked during a run.
- This occurs when all of the specified files matched exclusion rules, or none matched filtering rules.
Related issues/external references
Fixes squizlabs/PHP_CodeSniffer#1595