BCFile::getCondition()/Conditions::getCondition(): sync with PHPCS 3.5.4 / new $first parameter #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…5.4 / new $first parameter PHPCS 3.5.4 introduces a new `$first` parameter to the `File::getCondition()` function. The PHPCSUtils `Conditions::getCondition()` already had a parameter for the same - `$reverse`, though the boolean values used were also the reverse of how the new `$first` parameter is implemented. As PHPCSUtils is still in `alpha`, I'm making the executive decision to rename the parameter for the `Conditions::getCondition()` function to `$first`, including reversing the meaning of the boolean values, to stay in line with PHPCS itself. Includes adjusting any function calls in the existing codebase for the reversal of the meaning of the boolean. Includes moving the unit tests covering this parameter, which were already in place in the test file for the `Conditions::getCondition()` function, to the test file for the `BCFile::getCondition()` function. The actual tests will be run for both functions now. Refs: * squizlabs/PHP_CodeSniffer@77c5fa2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PHPCS 3.5.4 introduces a new
$firstparameter to theFile::getCondition()function.The PHPCSUtils
Conditions::getCondition()already had a parameter for the same -$reverse, though the boolean values used were also the reverse of how the new$firstparameter is implemented.As PHPCSUtils is still in
alpha, I'm making the executive decision to rename the parameter for theConditions::getCondition()function to$first, including reversing the meaning of the boolean values, to stay in line with PHPCS itself.Conditions::getCondition()function, to the test file for theBCFile::getCondition()function.The actual tests will be run for both functions now.
Refs: