Skip to content

PHP 8.5 | TestUtils: prevent deprecation notice for Reflection*::setAccessible() #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2025
Merged

PHP 8.5 | TestUtils: prevent deprecation notice for Reflection*::setAccessible() #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18dba71
PHP 8.5 | TestUtils: prevent deprecation notice for Reflection*::setA…
jrfnl Aug 9, 2025
01eb8b6
PHP 8.5 | Tests: prevent deprecation notice for Reflection*::setAcces…
jrfnl Aug 9, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions PHPCSUtils/TestUtils/ConfigDouble.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ private function preventAutoDiscoveryScreenWidth()
public function getStaticConfigProperty($name)
{
$property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
$property->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(true);

if ($name === 'overriddenDefaults' && \version_compare($this->phpcsVersion, '3.99.99', '>')) {
return $property->getValue($this);
Expand All @@ -236,14 +236,14 @@ public function getStaticConfigProperty($name)
public function setStaticConfigProperty($name, $value)
{
$property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
$property->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(true);

if ($name === 'overriddenDefaults' && \version_compare($this->phpcsVersion, '3.99.99', '>')) {
$property->setValue($this, $value);
} else {
$property->setValue(null, $value);
}

$property->setAccessible(false);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(false);
}
}
4 changes: 2 additions & 2 deletions PHPCSUtils/TestUtils/UtilityMethodTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,9 @@ public static function resetTestFile()
public static function setStaticConfigProperty($name, $value)
{
$property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
$property->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
$property->setValue(null, $value);
$property->setAccessible(false);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(false);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions Tests/AssertPropertySame.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ public static function getObjectPropertyValue($objectUnderTest, $propertyName)
return $objectUnderTest->$propertyName;
}

$property->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
$value = $property->getValue($objectUnderTest);
$property->setAccessible(false);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(false);

return $value;
} catch (ReflectionException $e) {
Expand Down
6 changes: 3 additions & 3 deletions Tests/TestUtils/ConfigDouble/ConfigDoubleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ public function testDestruct()
private function getStaticConfigProperty($name, $config = null)
{
$property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
$property->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(true);

if ($name === 'overriddenDefaults' && \version_compare(Helper::getVersion(), '3.99.99', '>')) {
// The `overriddenDefaults` property is no longer static on PHPCS 4.0+.
Expand Down Expand Up @@ -330,8 +330,8 @@ public static function setStaticConfigProperty($name, $value)
}

$property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
$property->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
$property->setValue(null, $value);
$property->setAccessible(false);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(false);
}
}
2 changes: 1 addition & 1 deletion Tests/TestUtils/UtilityMethodTestCase/ResetTestFileTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public function testTearDownCleansUpStaticConfigProperties()
private function getStaticConfigProperty($name, $config = null)
{
$property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
$property->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $property->setAccessible(true);

if ($name === 'overriddenDefaults'
&& (self::$phpcsVersion === '0' || \version_compare(self::$phpcsVersion, '3.99.99', '>'))
Expand Down
4 changes: 2 additions & 2 deletions Tests/Tokens/Collections/PropertyBasedTokenArraysTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ final class PropertyBasedTokenArraysTest extends TestCase
public function testPropertyBasedTokenArrays($name)
{
$reflProp = new ReflectionProperty('PHPCSUtils\Tokens\Collections', $name);
$reflProp->setAccessible(true);
(\PHP_VERSION_ID < 80100) && $reflProp->setAccessible(true);
$expected = $reflProp->getValue();
$reflProp->setAccessible(false);
(\PHP_VERSION_ID < 80100) && $reflProp->setAccessible(false);

$this->assertSame($expected, Collections::$name());
}
Expand Down