BCFile::getDeclarationName(): sync with upstream #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The upstream File::getDeclarationName() method is slated to receive a bug fix in the PHPCS 3.12.0 release to prevent incorrect results for unfinished closures with typed parameters. The PHPCSUtils native `ObjectDeclarations::getName()` method already handled this correct. This commit polyfills the upstream method via the BCFile class and syncs the tests with the upstream changes. Ref: PHPCSStandards/PHP_CodeSniffer 816
jrfnl force-pushed the feature/getdeclarationname-sync-with-upstream branch from eb8a591 to d44b561 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
⚠️ Wait with merging until the upstream PR has been accepted! ⚠️ The upstream File::getDeclarationName() method is slated to receive a bug fix in the PHPCS 3.12.0 release to prevent incorrect results for unfinished closures with typed parameters.
The PHPCSUtils native
ObjectDeclarations::getName()method already handled this correctly.This commit polyfills the upstream method via the BCFile class and syncs the tests with the upstream changes.
Ref: PHPCSStandards/PHP_CodeSniffer#816