Skip to content

UtilityMethodTestCase::resetTestFile(): stabilize the resetting #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

UtilityMethodTestCase::resetTestFile(): stabilize the resetting #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions PHPCSUtils/TestUtils/UtilityMethodTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ public function skipJSCSSTestsOnPHPCS4()
}

/**
* Clean up after finished test.
* Clean up after finished test by resetting all static properties to their default values.
*
* Note: This is a PHPUnit cross-version compatible {@see \PHPUnit\Framework\TestCase::tearDownAfterClass()}
* method.
Expand All @@ -309,7 +309,12 @@ public function skipJSCSSTestsOnPHPCS4()
*/
public static function resetTestFile()
{
self::$phpcsFile = null;
self::$phpcsVersion = '0';
self::$fileExtension = 'inc';
self::$caseFile = '';
self::$tabWidth = 4;
self::$phpcsFile = null;
self::$selectedSniff = ['Dummy.Dummy.Dummy'];
}

/**
Expand Down
7 changes: 6 additions & 1 deletion Tests/TestUtils/UtilityMethodTestCase/UtilityMethodTestCaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ public function testGetTargetTokenNotFoundException()
public function testTearDown()
{
parent::resetTestFile();
$this->assertNull(self::$phpcsFile);
$this->assertSame('0', self::$phpcsVersion, 'phpcsVersion was not reset');
$this->assertSame('inc', self::$fileExtension, 'fileExtension was not reset');
$this->assertSame('', self::$caseFile, 'caseFile was not reset');
$this->assertSame(4, self::$tabWidth, 'tabWidth was not reset');
$this->assertNull(self::$phpcsFile, 'phpcsFile was not reset');
$this->assertSame(['Dummy.Dummy.Dummy'], self::$selectedSniff, 'selectedSniff was not reset');
}
}