Skip to content

Conversation

@tpluscode
Copy link
Contributor

also added imports make it clear what is needed for the code

As a side note, I think it's rather redundant to include the instructions separate for JS and TS. They are virtually identical

also added imports make it clear what is needed for the code
@AlexZeitler
Copy link
Contributor

Thanks for the feedback regarding JS/TS docs. I was thinking a lot about if this is necessary and just pushed both waiting for feedback like this.

If you like, you can remove one of them. I tend to remove the TS version as JS is the lowest common denominator.

@AlexZeitler
Copy link
Contributor

@tpluscode Do you want to remove the duplicate JS/TS parts or do you want me to merge the current state of the PR?

@tpluscode
Copy link
Contributor Author

In a separate PR maybe

@AlexZeitler AlexZeitler merged commit 844e712 into PDMLab:master Oct 27, 2019
@AlexZeitler
Copy link
Contributor

Thanks 📦 version 0.1.1 has been published on npm.

@tpluscode tpluscode deleted the readme branch October 27, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants