4 param express handler

[tpluscode]

fixes #7

[AlexZeitler]

Thanks, 📦 express-http-problem-details@0.1.2 has been released.

[AlexZeitler]

I'm just wondering if the release number should have been 0.2.0 after merging and releasing this PR?

At least thats how I understood the FAQ:

fix type commits should be translated to PATCH releases. feat type commits should be translated to MINOR releases. Commits with BREAKING CHANGE in the commits, regardless of type, should be translated to MAJOR releases.

Did I do something wrong?

[tpluscode]

Indeed it should have. I did not pay attention to that.

Did you pass any parameters to standard-version?

[AlexZeitler]

No, I just ran yarn release

[AlexZeitler]

Same happened for the other libs where we added standard-version

[tpluscode]

That is strange indeed. I've been using these tools for a few months now without such issues.

One thing though. Have you been squashing these PRs?

Doesn't look like it...

[AlexZeitler]

No I didn't squash them. So I should squash and use a conventional commit style message for it?

[tpluscode]

That is a choice. I asked because squashing essentially discard the original commits from history. So the feat: could get lost and thus distorting the result of standard-version.

[AlexZeitler]

Yes, that's why I did not squash until now. If I squash I would have to find the correct type of conventional commit type myself which imho would render usage of a tool like conventional commit / standard-version sort of less useful.

[AlexZeitler]

Maybe I didn't read the manuals correctly but I didn't find something like "this is your workflow now"

[tpluscode]

If I squash I would have to find the correct type of conventional commit type myself which imho would render usage of a tool like conventional commit / standard-version sort of less useful.

Yes. I stopped squashing since I use conventional commits. And I pay much more attention to meaningful and cohesive commits. Before it was a mess.

Maybe I didn't read the manuals correctly but I didn't find something like "this is your workflow now"

I don't follow

[AlexZeitler]

If I squash I would have to find the correct type of conventional commit type myself which imho would render usage of a tool like conventional commit / standard-version sort of less useful.

Yes. I stopped squashing since I use conventional commits. And I pay much more attention to meaningful and cohesive commits. Before it was a mess.

So I should not have done it wrong here?

Maybe I didn't read the manuals correctly but I didn't find something like "this is your workflow now"

I don't follow

I mean: An example where the workflow using cc/sv is shown end to end.