Updates 'validate-pr.yml' to use 'env:flowout --useLocalRepo' #5
Conversation
.github/workflows/validate-pr.yml Outdated
| - name: Check out merge result | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ github.merge_commit_sha }} |
There was a problem hiding this comment.
Is this definitely the correct variable? I was expecting github.event.pull_request.merge_commit_sha
There was a problem hiding this comment.
It definitely works, it yields a full commit hash.
But I think maybe we should just remove the ref input altogether because I think when triggered by a PR, that's the default behavior?
There was a problem hiding this comment.
Ah that's possibly how this is working then, because there's no property like this on the github context according to the docs: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
There was a problem hiding this comment.
No no, I printed the value of it whilst developing, it printed a full commit hash.
There was a problem hiding this comment.
Or, hm... actually maybe it was the checkout action that printed it.
There was a problem hiding this comment.
Yeah the checkout action defaults to github.ref if no value is supplied. And in the context of a PR, github.ref is the merge branch
| - cron: "0 1 * * *" # Runs nightly at 01:00 UTC. | ||
| # Uncomment to run this workflow on a schedule: | ||
| #schedule: | ||
| # - cron: "0 1 * * *" # Run nightly at 01:00 UTC. |
There was a problem hiding this comment.
Might be wise to change this schedule because it clashes with the merge from production schedule
There was a problem hiding this comment.
What do you reckon we should change it to? 4 times throughout the working day? 9, 12, 15 and 18?
2 participants
Also: