Skip to content

Conversation

@paynecrl97
Copy link
Member

Also:

  • Makes use of some new features- tagging, --nameOnly, and --waitForLock
  • Adds exclusion specs for known flaky metadata types
  • Changes production env's branch name to main (as it's more representative of a real repo)
  • Changes 3rd party test result publishing to a more reliable action
  • Updates workflow names to better reflect what they do
  • Clarifies and updates documentation & comments
@paynecrl97 paynecrl97 requested a review from DaRosenberg October 2, 2022 21:26
Copy link
Contributor

@DaRosenberg DaRosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

echo "::set-output name=environment-name::$output";
# Print a message if at least one branch does not correspond to an environment:
- name: End with success if one of the branches does not correspond an OrgFlow environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: End with success if one of the branches does not correspond an OrgFlow environment
- name: Ensure both branches are OrgFlow environments

(Just to keep step names roughly the same length and verbosity.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the name of this step is awkward because:

  • it doesn't (and can't) end the job
  • it's just a nicety to make it more explicit why subsequent steps are skipped
  • this step is skipped if the branches are OrgFlow branches, which makes wording along the lines of 'ensure' or 'check' awkward

In the end I went with 'End with success' because it produces much clearer output in the job's log. i.e. you can see why subsequent steps are skipped, and this step is only ever executed in this case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eg OrgFlow branches:

image

and non-OrgFlow branches

image

@paynecrl97 paynecrl97 merged commit e3ae588 into main Oct 4, 2022
@paynecrl97 paynecrl97 deleted the backPromote branch October 4, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants