Display Save times in user locale and timezone #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits February 24, 2022 15:26
Display save times in locale instead of ISO UTC
Closed
Contributor Author
| Looks like it's trying to use version* 64 of node-sass which is no longer available prebuilt. So then it's trying to build it but is either missing the required configuration or toolchain to do so properly. On my windows system it built without errors but it fetched node-sass version 83 rather than 64. I'm not super familiar with node module versioning or package locking so I'm not sure why mine built with 83 and the automated test tried to use 64. But in either case I don't think this is an issue with my change, and I do think this same issue is causing PR #313 to also fail even though that change only was affecting the go server.
|
Member
| Thanks @FrederickDoering! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This changes the displayed date-time format on the save page from ISO UTC to the user's locale and timezone as defined by their web browser. This should fix/close issue #299.