Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jun 1, 2023

Remove csharp client generator (the latest version supported is v4.5.2 which had its end of life on April 26, 2022)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh 
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date 
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)

@wing328 wing328 marked this pull request as ready for review June 1, 2023 06:50
@wing328 wing328 merged commit 421bcd1 into master Jun 2, 2023
@wing328 wing328 deleted the deco-csharp branch June 2, 2023 12:42
@CADbloke
Copy link

CADbloke commented Jun 4, 2023

WHAT? You know 4.5.2 is backwards compatible with 4.8.x, whose End of Life is Yet to be determined. .NET framework will go away when COBOL goes away.
👎

fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
* remove csharp client generator * update samples/docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment