Skip to content

Conversation

@loleary
Copy link
Contributor

@loleary loleary commented Nov 14, 2022

Fix #13648

Change from packagePath() to packageName when generating the Python import statement.

@spacether

Test command:

$ java -jar ./modules/openapi-generator-cli/target/openapi-generator-cli.jar \ generate \ -i ./modules/openapi-generator/src/test/resources/3_0/petstore.yaml \ -g python \ --additional-properties packageName='my.openapi' \ -o /tmp/issue-13648

Before:

$ tail -n2 /tmp/issue-13648/my/openapi/model/pet.py from my/openapi.model.category import Category from my/openapi.model.tag import Tag

After:

$ tail -n2 /tmp/issue-13648/my/openapi/model/pet.py from my.openapi.model.category import Category from my.openapi.model.tag import Tag

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh 
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@spacether spacether added this to the 6.3.0 milestone Nov 14, 2022
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the fix and the verification test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants