Skip to content

Conversation

@Rukoto
Copy link

@Rukoto Rukoto commented Jun 7, 2018

Changes:

  • Fixed many translation mistakes
  • Replaced some keywords with appropriate ones
  • Added a missing resource to ja-JP.dll
    (Resources not necessary for Japanese have been omitted from ja-JP.dll. ex: Right To Left)
@coddec coddec requested review from a team, Quentinix, XenHat, coddec and ge0rdi and removed request for a team June 7, 2018 04:26
Copy link
Member

@coddec coddec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea about Japanese, but mostly seems should be OK?
How would us deal with these situation in the future?
How would us proofread the translation?

@Rukoto
Copy link
Author

Rukoto commented Jun 7, 2018

First of all, I appreciate that you confirmed the content.

The content of this pull request was reported before Ivo finished development,
As I needed to make lots of corrections, the report was delayed and eventually was not included in the Classic Shell.

In a famous Japanese forum, I know that these files were published in Classic Shell's forum and in my repository,
In this forum, there is no problem report on my translation.
However, I realize that this fact is irrelevant to the quality of the file.

Are you planning to set up a forum, not limited to topics of translation?
In addition to translation, I feel that a place where users can talk is necessary.

@coddec
Copy link
Member

coddec commented Jun 7, 2018

@Rukoto
First of all, thank you very much for the hard work, we appreciate your contribution and other's contribution!

As all of us know that people makes mistakes, that's why I always want to double confirm 😄

Yes, I saw the issue here https://github.com/passionate-coder/Classic-Start/issues/7
For sure I agree with you that

In addition to translation, I feel that a place where users can talk is necessary.

I'll see what can we do.

Meanwhile, anyone has thoughts on using Gitter as a replacement of forum?
The reason behind it is, most of free forum provider seems either put lot's of ADs or short-life product (Unreliable) Gitter otherwise seems at least can be a place to gather the community together and talk to each other, especially for non-coders.
One important thing that I want to know is are there any limitation of no. of users in a public room? Anyone can confirm that for me? If no, I guess we can move on to use that replacement of forum.

@coddec
Copy link
Member

coddec commented Jun 7, 2018

@ge0rdi @XenHat @Quentinix
Anyone? Any thoughts?
Should we merge?
😃

@coddec
Copy link
Member

coddec commented Jun 7, 2018

@Rukoto @ge0rdi
Probably merge of translation is fine.
One question is how did you produce ja-JP.dll? If it's utilized other parts from classic shell e.g. .bat and other resource file, does it mean that there are other parts need to be corrected or they are all here?
Sorry for this type of dumb question...
Correct if I'm wrong.

Thanks!

@Rukoto
Copy link
Author

Rukoto commented Jun 7, 2018

I made ja-JP.dll using Resource Hacker.
In en-US.dll in the repository, some resources required for translation are missing.
So I first made en-US.dll which is a template.

  1. Get "Resource Hacker" and run it.
  2. Import [L10N], [Version Info], [Manifest] from en-US.dll in the repository from "Add from a Resouce file".
  3. Import the [Dialog], [String Table] group from 'ClassicExplorer32.dll', 'ClassicIEDLL_32.dll', 'ClassicStartMenuDLL.dll', 'ClassicShellUpdate.exe' which exists in the installation folder of Classic Shell.
  4. Delete only "7" in [String Table] group .
  5. Correct the contents (version number etc.) of [Version Info] group.
  6. Save it as en-US.dll. (However, you should prepare the template en-US.dll which was originally built in the development environment.)
  7. Edit the string in en-US.dll with Resource Hacker and save it as ja-JP.dll.

I am sorry, but I do not know about the correct way to build en-US.dll.

By exporting to RC file, we can proofread translations by someone else.
When managing translation changes, you need to be careful to publish a text file (eg *.rc) and synchronize it with the DLL file.

@coddec
Copy link
Member

coddec commented Jun 7, 2018

Hi @Rukoto thank you very much for those important details!
I guess we need to work on this together @ge0rdi @XenHat @Quentinix
To double confirm there's no issue with the complete set of the program?
I mean... I'm not confident with dll & compiling stuff on my own...
Or should we???

@Rukoto You've successfully compiled and ran the program I guess?

@Rukoto
Copy link
Author

Rukoto commented Jun 7, 2018

@coddec

AppVeyor succeeded in building. I used the program for a while but I do not think there is any problem.
If the language file version is higher than the main version, the language file was not applied.
This was an unexpected discovery:open_mouth:

@coddec
Copy link
Member

coddec commented Jun 7, 2018

@Rukoto
Aha 👍
That's why double or triple confirm kicks in 😃
Good catch!
Well... I can tell you that... you probably know more about classic shell than I do 😉😉
That's why I want our team check it out 🤣
If it's only me, I probably have clicked on Merge pull request, till later we found the issue... and endless debug process begins 😆

@coddec
Copy link
Member

coddec commented Jun 7, 2018

The new place for community to communicate is set now with Gitter.
https://gitq.com/passionate-coder/Classic-Start
https://gitter.im/passionate-coder
Seems they do not have limitation on no. of users in a public room, or way higher than the number of members exist on classic shell forum.
@Rukoto

@coddec coddec added enhancement help wanted Extra attention is needed labels Jun 10, 2018
@XenHat
Copy link
Member

XenHat commented Jun 25, 2018

Due to rebranding and name change, these translations need to be updated. :(
cc @Rukoto

@coddec
Copy link
Member

coddec commented Jun 25, 2018

@XenHat Just a quick reminder, we might need to be aware of versioning & translation problem mentioned earlier within this issue, just in case 👍

@XenHat
Copy link
Member

XenHat commented Jun 25, 2018

Reading Localization.rtf, I found a few things:

  • We do not have a CSV -> DLL converter (Ivo used to accept .csv and created a DLL from that).
  • DLL editing is only one of the supported translation methods
  • The DLL are regenerated as needed, and only used to override the L10N files
  • The main method to translate Classic Start is to edit the three (3) L10N.ini files:
    1. ClassicStartSrc/ClassicExplorer/ExplorerL10N.ini
    2. ClassicStartSrc/ClassicStartMenu/StartMenuL10N.ini
    3. ClassicStartSrc/ClassicStartMenu/StartMenuHelper/StartMenuHelperL10N.ini
    • Installer translation:
      • ClassicStartSrc/Localization/WixUI/<lang>.wxl (plain text)
    • Policy translation:
      • ClassicStartSrc/Localization/<language>/*ADMX.txt files

ClassicStartLoc appears to be an example and is not referenced anywhere in the code or the build scripts. It can probably be removed.

@Rukoto in your care you need to modify the section titled [ja-JP] - Japanese (Japan):
image
etc

@coddec
Copy link
Member

coddec commented Jun 25, 2018

👍
Super speed investigation....

@coddec
Copy link
Member

coddec commented Jun 25, 2018

Not really relevant to this issue: Was digging on alternatives of transifex, no luck

@XenHat
Copy link
Member

XenHat commented Jun 25, 2018

Not really relevant to this issue: Was digging on alternatives of transifex, no luck

I don't really see the need for a big platform like that for this project.
The files could be relocated somewhere more obvious, perhaps, but I prefer plan text editing when it comes to this.

@coddec
Copy link
Member

coddec commented Jun 25, 2018

All good, thought it might make crowdsourcing easier, but yes, I agree it can be over kill for now😄

@Rukoto
Copy link
Author

Rukoto commented Jun 25, 2018

@XenHat Thank you for doing a detailed investigation.
It is very useful to understand what kind of procedure the translation is realized.

@coddec It is regrettable that the quality of Japanese translation will remain low,
At this stage I decided that this pull request should be closed.

I think that it is possible to immediately replace the text file, but I will skip this time.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

3 participants