Skip to content

Conversation

@AEAEAEAE4343
Copy link

@AEAEAEAE4343 AEAEAEAE4343 commented Jan 26, 2021

Added 2 options:
Align to work area: This aligns the start menu to the working area instead of aligning it against the border of the taskbar. This is useful if you're using a custom taskbar that has different dimensions from Shell_TrayWnd
Horizontal/Vertical menu offset: This moves the menu around by the defined offset
Fixed #558

… the edge of working area instead of against the taskbar
@ge0rdi
Copy link
Member

ge0rdi commented Jan 27, 2021

Please, remove all the empty .vcxproj.FileListAbsolute.txt files. They were probably added by mistake.

You can amend the commit locally and then force push (git push -f).

Copy link
Member

@ge0rdi ge0rdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just few minor formatting issues.

@AEAEAEAE4343
Copy link
Author

Thanks for the feedback! The indentation issues are caused by Visual Studio, because I have my settings on Tabs instead of Spaces, easy fix. The rest should also be easy.

Copy link
Member

@ge0rdi ge0rdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still few formatting issues, but we are getting there :)

@ge0rdi
Copy link
Member

ge0rdi commented Jan 27, 2021

Looks good now.
Please squash all the commits into single commit. There is no need to keep partial development fixes.

It should basically have commit message as your first commit.

ge0rdi
ge0rdi previously approved these changes Jan 27, 2021
@AEAEAEAE4343
Copy link
Author

Everything should be good now.

@bonzibudd
Copy link
Member

Hi, not sure if this is worth mentioning, but I got an error during upgrade: "Open-Shell update.ink could not be set." I would post a screenshot but I already clicked away from it. Does this need to be looked into?

@ge0rdi
Copy link
Member

ge0rdi commented Jan 27, 2021

@bonzibudd
Are you able to replicate it?
What version are you upgrading from?

I can't see how it could be related to changes in this PR.

@bonzibudd
Copy link
Member

Actually, I am not able to replicate it on a different machine, it might be something to do with my main installation. Sorry for the seemingly false alarm, I'll make sure I don't see any other issues.

@ge0rdi
Copy link
Member

ge0rdi commented Jan 27, 2021

@bonzibudd
No problem at all.

I'm happy that you are testing this 👍

@ge0rdi
Copy link
Member

ge0rdi commented Feb 9, 2021

Sorry guys, I totally forgot about this.
Merging now.

@ge0rdi ge0rdi merged commit 8e1b4e3 into Open-Shell:master Feb 9, 2021
@Open-Shell Open-Shell deleted a comment from blackcrack Jul 31, 2023
@ge0rdi ge0rdi mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants