- Notifications
You must be signed in to change notification settings - Fork 471
Added some options for moving around the start menu #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the edge of working area instead of against the taskbar
| ✅ Build Open-Shell-Menu 4.4.163-beundvxb completed (commit d1a4bb8186 by @) |
| Please, remove all the empty You can amend the commit locally and then force push ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Just few minor formatting issues.
| Thanks for the feedback! The indentation issues are caused by Visual Studio, because I have my settings on Tabs instead of Spaces, easy fix. The rest should also be easy. |
| ✅ Build Open-Shell-Menu 4.4.163-elebobuq completed (commit 5c1d2bf4db by @) |
| ✅ Build Open-Shell-Menu 4.4.163-jkyqimkh completed (commit 6391f65d10 by @) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still few formatting issues, but we are getting there :)
| ✅ Build Open-Shell-Menu 4.4.163-gkwaxglw completed (commit df90ba56ca by @) |
| Looks good now. It should basically have commit message as your first commit. |
| ✅ Build Open-Shell-Menu 4.4.163-drxkfiil completed (commit f204a72e9e by @) |
| ✅ Build Open-Shell-Menu 4.4.163-sfydlojv completed (commit 0ce1c83aea by @) |
| Everything should be good now. |
| ✅ Build Open-Shell-Menu 4.4.163-ltxtlqut completed (commit b6107b6f47 by @) |
| ✅ Build Open-Shell-Menu 4.4.163-mpcrioao completed (commit c6d55582c1 by @) |
| Hi, not sure if this is worth mentioning, but I got an error during upgrade: "Open-Shell update.ink could not be set." I would post a screenshot but I already clicked away from it. Does this need to be looked into? |
| @bonzibudd I can't see how it could be related to changes in this PR. |
| Actually, I am not able to replicate it on a different machine, it might be something to do with my main installation. Sorry for the seemingly false alarm, I'll make sure I don't see any other issues. |
| @bonzibudd I'm happy that you are testing this 👍 |
| Sorry guys, I totally forgot about this. |
Added 2 options:
Align to work area: This aligns the start menu to the working area instead of aligning it against the border of the taskbar. This is useful if you're using a custom taskbar that has different dimensions from Shell_TrayWnd
Horizontal/Vertical menu offset: This moves the menu around by the defined offset
Fixed #558