Rebrand to Open-Shell (#36) #58

XenHat · 2018-08-04T06:02:11Z

~~No description provided~~
Just what's in #36. Change name to avoid copyright issues.

ge0rdi · 2018-08-04T18:16:44Z

appveyor.yml

@@ -5,9 +5,9 @@ skip_tags: true
 image: Visual Studio 2017
 clone_depth: 1
 build_script:
- cmd: ClassicStartSrc\ClassicStartSetup\__MakeFinal.bat
+- cmd: OpenShellSrc\Setup\__MakeFinal.bat


Src\Setup\__MakeFinal.bat

ge0rdi · 2018-08-04T18:17:37Z

appveyor.yml

 test: off
 only_commits:
 files:
- - ClassicStartSrc/
- - ClassicStartLoc/
+ - OpenShellSrc/


Src/
Localization/

ge0rdi · 2018-08-04T18:33:55Z

Src/BUILDME.txt

+The final files (installers, archives) are saved to the Setup\Final folder.

 You need the following tools:
 Visual Studio 2017 (Community Edition is enough)


This should be updated since you changed SDK version to 10.0.17134.0.

Yeah sorry about that, I didn't have the old SDK version

No problem at all. In fact its good to move to latest SDK.
Though this could've rather be separate commit as it is unrelated to re-branding.

I agree but making this build and renaming was a horrible mess and I had to re-do it twice already

ge0rdi · 2018-08-04T18:38:57Z

README.md

 [Classic Shell - Custom Start Buttons](https://coddec.github.io/Classic-Shell/www.classicshell.net/tutorials/buttontutorial.html)

-[Report a bug/issue or submit a feature request](https://github.com/NeoClassic-UI/Menu/issues)
+[Report a bug/issue or submit a feature request](https://github.com/Open-Shell/Menu/issues)


Should be https://github.com/Open-Shell/Open-Shell-Menu/issues.

ge0rdi · 2018-08-04T18:40:40Z

README.md

+[Discussion room](https://gitter.im/Open-Shell)

-[Latest nightly build](https://ci.appveyor.com/project/passionate-coder/menu/branch/master/artifacts)
+[Latest nightly build](https://ci.appveyor.com/project/open-shell/menu/branch/master/artifacts)


We didn't change AppVeyor's account name yet (it should be possible but not sure whether everything will work after that).
So I'd leave this as it was for now.

Unintended, mass replace ate that one.

ge0rdi · 2018-08-04T18:41:57Z

README.md

@@ -1,14 +1,14 @@
-## Classic Start ![Classic Start](/ClassicStartSrc/ClassicStartSetup/ClassicStart.ico)
+## Open-Shell ![Open-Shell](/OpenShellSrc/Setup/OpenShell.ico)


Should be /Src/Setup/OpenShell.ico.

ge0rdi · 2018-08-04T18:44:04Z

README.md

 *Originally* **[Classic Shell](http://www.classicshell.net)** *by [Ivo Beltchev](https://sourceforge.net/u/ibeltchev/profile/)*

-[![GitHub Release](https://img.shields.io/github/release/NeoClassic-UI/Menu.svg)](https://github.com/NeoClassic-UI/Menu/releases) [![GitHub Pre-Release](https://img.shields.io/github/release/NeoClassic-UI/Menu/all.svg)](https://github.com/NeoClassic-UI/Menu/releases) [![Build status](https://ci.appveyor.com/api/projects/status/6ydldy3ijsa4dkgb/branch/master?svg=true)](https://ci.appveyor.com/project/passionate-coder/menu/branch/master) [![GitQ](https://gitq.com/badge.svg)](https://gitq.com/passionate-coder/Classic-Start) [![Gitter chat](https://badges.gitter.im/gitterHQ/gitter.png)](https://gitter.im/passionate-coder/Disc-Chitchat)
+[![GitHub Release](https://img.shields.io/github/release/Open-Shell/Menu.svg)](https://github.com/Open-Shell/Menu/releases) [![GitHub Pre-Release](https://img.shields.io/github/release/Open-Shell/Menu/all.svg)](https://github.com/Open-Shell/Menu/releases) [![Build status](https://ci.appveyor.com/api/projects/status/6ydldy3ijsa4dkgb/branch/master?svg=true)](https://ci.appveyor.com/project/passionate-coder/menu/branch/master) [![GitQ](https://gitq.com/badge.svg)](https://gitq.com/passionate-coder/Classic-Start) [![Gitter chat](https://badges.gitter.im/gitterHQ/gitter.png)](https://gitter.im/open-shell/Lobby)


Releases links should be https://github.com/Open-Shell/Open-Shell-Menu/releases.
Badges should point to https://img.shields.io/github/release/Open-Shell/Open-Shell-Menu.

ge0rdi · 2018-08-04T18:52:39Z

Src/Lib/Lib.filters

 </Filter>
 <Filter Include="Lib">
 <UniqueIdentifier>{40e914e4-1c35-4b97-a4f6-15dce5ff5b20}</UniqueIdentifier>
 </Filter>


This file should be called Lib.vcxproj.filters.

That's very odd. I did compile the entire project several times before comitting.

This doesn't affect compilation. Nor VS (it seems). Though it seems VS is following this convention when you create new projects.

ge0rdi · 2018-08-04T18:59:17Z

Src/Menu/MenuDLL/OpenShellButton.cpp

@@ -0,0 +1,715 @@
+// Classic Shell (c) 2009-2017, Ivo Beltchev


Could we call this StartButton.cpp (+ respective .h)?
Other files don't have OpenShell prefix.

ge0rdi · 2018-08-04T19:02:24Z

Could we rename Src/Menu to Src/StartMenu?
Also then Src/Menu/MenuDLL to Src/StartMenu/StartMenuDLL.

That would better describe the content of the folder (Menu is too generic).

Also resulting binaries should rather be called StartMenu.exe and StartMenuDLL.dll (eventually StartMenu.dll).

ge0rdi · 2018-08-04T19:03:25Z

Also please squash those commits into single one (at least to remove those commits that shuffled facebook stuff here and there).

XenHat · 2018-08-04T20:04:10Z

@ge0rdi

Also please squash those commits into single one (at least to remove those commits that shuffled facebook stuff here and there).

I'll do what I can... I'm not extremely familiar with Git.

ge0rdi · 2018-08-04T20:10:42Z

I'll do what I can... I'm not extremely familiar with Git.

See for example here:
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Then you have to force push (git push -f).

changed code

ge0rdi

Looks better now :)
Though appveyor.yml and README.md is still missing fixes.

XenHat · 2018-08-05T12:19:31Z

@ge0rdi Git ate the changes. Pushed.

Pushed readme changes

ge0rdi

Looks good.
Please, squash all changes before merge.

XenHat requested review from coddec and ge0rdi August 4, 2018 06:02

coddec previously approved these changes Aug 4, 2018

View reviewed changes

ge0rdi previously requested changes Aug 4, 2018

View reviewed changes

Rebrand to Open-Shell

2a7008b

XenHat requested a review from ge0rdi August 4, 2018 20:26

XenHat added 2 commits August 4, 2018 18:57

Code review

07cf1f5

Slight installer branding improvement

5365e6b

ge0rdi previously requested changes Aug 5, 2018

View reviewed changes

re-do README changes that somehow got lost

d5f9399

XenHat requested a review from ge0rdi August 5, 2018 12:29

Add appveyor changes

83df3e4

ge0rdi approved these changes Aug 5, 2018

View reviewed changes

XenHat merged commit f4dd561 into Open-Shell:master Aug 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rebrand to Open-Shell (#36) #58

Rebrand to Open-Shell (#36) #58

Uh oh!

XenHat commented Aug 4, 2018 •

edited

Loading

ge0rdi Aug 4, 2018

XenHat Aug 4, 2018

ge0rdi Aug 4, 2018

ge0rdi Aug 4, 2018

XenHat Aug 4, 2018

ge0rdi Aug 4, 2018

XenHat Aug 4, 2018

ge0rdi Aug 4, 2018

ge0rdi Aug 4, 2018

XenHat Aug 4, 2018

ge0rdi Aug 4, 2018

ge0rdi Aug 4, 2018

ge0rdi Aug 4, 2018

XenHat Aug 4, 2018

ge0rdi Aug 4, 2018

ge0rdi Aug 4, 2018

ge0rdi commented Aug 4, 2018 •

edited

Loading

ge0rdi commented Aug 4, 2018

XenHat commented Aug 4, 2018

ge0rdi commented Aug 4, 2018

ge0rdi left a comment

XenHat commented Aug 5, 2018 •

edited

Loading

ge0rdi left a comment

Labels

3 participants

		@@ -1,14 +1,14 @@
		## Classic Start ![Classic Start](/ClassicStartSrc/ClassicStartSetup/ClassicStart.ico)
		## Open-Shell ![Open-Shell](/OpenShellSrc/Setup/OpenShell.ico)

		@@ -0,0 +1,715 @@
		// Classic Shell (c) 2009-2017, Ivo Beltchev

Rebrand to Open-Shell (#36) #58

Rebrand to Open-Shell (#36) #58

Uh oh!

Conversation

XenHat commented Aug 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ge0rdi commented Aug 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ge0rdi commented Aug 4, 2018

XenHat commented Aug 4, 2018

ge0rdi commented Aug 4, 2018

ge0rdi left a comment

Choose a reason for hiding this comment

XenHat commented Aug 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ge0rdi left a comment

Choose a reason for hiding this comment

Labels

3 participants

XenHat commented Aug 4, 2018 •

edited

Loading

ge0rdi commented Aug 4, 2018 •

edited

Loading

XenHat commented Aug 5, 2018 •

edited

Loading