Skip to content

Conversation

@blackcrack
Copy link

remove the empty lines
and update url and versioning

@Ibuprophen
Copy link
Member

Any thoughts @ge0rdi or @coddec?

~Ibuprophen

@blackcrack
Copy link
Author

@Ibuprophen

  1. => 4.4.139-suivthvv .. cool s

i have tomorrow free.. and in the next 2nd day have i nightshift, there want i test it :))))

best regards
Blacky

Copy link
Member

@Ibuprophen Ibuprophen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ blackcrack, why (on a few lines) did you delete and then provide an addition to information that are actually identical to each other?

I, personally, am not seeing any value to this but, if I'm seeing it wrong, please elaborate.

Thank you! :-)

~Ibuprophen

@blackcrack
Copy link
Author

blackcrack commented Sep 5, 2019

@Ibuprophen
3-10 was a big hole, this couple messy lines have i removed..
this have changed the whole changes and have bring up the whole changed lines,
because.. a.E. i have changed the homepages http://www.classicshell.net/ => https://open-shell.github.io
edit: woooppss: lack of the last adressletters have broke the homepage adress, fixed ! (commit 2)
=> Buildbot have builded : 4.4.141-xnotrdgd (how cool is that !! we are can update our Openshell by own !! uuuhhhhhh coooollllll )

this have give the changed lines of 15, 22, 34 if you look direktly
on this lines did i change nothing and must be comes out of removing of the lines between 2-10..
what else can not it be, *shrug*

best regards
Blacky

uuu000ps, i must ad the last path of the homepage or the link is.. was broken ... https://open-shell.github.io/Open-Shell-Menu => /Open-Shell-Menu/
@Ibuprophen
Copy link
Member

What do you think @coddec, @ge0rdi and/or @XenHat?

Just looking for a 2nd+ Opinion...

~Ibuprophen

Copy link
Member

@ge0rdi ge0rdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change those links in all files in Src\Localization\German in single PR.
There is no need to create separate PR for each file (and even duplicate ones).

Ideally you can change those links also for other languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants