Skip to content

Conversation

AllieTheFox
Copy link

For a couple years now, building ClassicExplorerSettings in x64 was not possible due to

  1. Missing the x64 build configurations all together
  2. Always trying to load ClassicExplorer32.dll no matter the architecture
@ge0rdi
Copy link
Member

ge0rdi commented Apr 23, 2025

Is there a problem with current state?

We are using also 32bit binaries on 64bit system. So it is pretty fine to have just 32bit version of ClassicExplorerSettings.
Unless there is some issue with that (we are not aware of any such issue).

@AllieTheFox
Copy link
Author

AllieTheFox commented Apr 25, 2025

Is there a problem with current state?

We are using also 32bit binaries on 64bit system. So it is pretty fine to have just 32bit version of ClassicExplorerSettings. Unless there is some issue with that (we are not aware of any such issue).

Is there any reason why it shouldn't be done? I mean Microsoft doesn't even ship x86 builds of Windows 11 these days so why cling onto x86 binaries? There is really no downside to making it fully x64 buildable

@ge0rdi
Copy link
Member

ge0rdi commented Apr 25, 2025

If you want to pursue this, then please adjust also build/installer part so that x64 version of ClassicExplorerSettings.exe is included in 64bit installer.

You may need to adjust BuildBinaries.bat where binaries are copied to Output folder.
And then also Setup.wxs where the binary is referenced to be included in MSI installer.

Basically look for ClassicExplorerSettings.exe references in these files and adjust for x64 accordingly.

@ge0rdi ge0rdi self-requested a review April 25, 2025 13:06
@Neustradamus
Copy link

To follow this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants