Skip to content

Conversation

@ge0rdi
Copy link
Member

@ge0rdi ge0rdi commented Feb 1, 2023

No description provided.

@ge0rdi ge0rdi requested a review from bonzibudd February 1, 2023 17:27
@ge0rdi
Copy link
Member Author

ge0rdi commented Feb 1, 2023

@bonzibudd
Could you please check skin changes, if everything still works as it should?

Also will be great if you can check if those tutorials are up to date.

@vodek3
Copy link

vodek3 commented Feb 1, 2023

Зашибись!

@bonzibudd
Copy link
Member

Not sure if it makes a functional difference, but the new help files should be mentioned in OpenShellTOC.hhc. It may be required for the side panel navigation, but I can’t test right now.

@ge0rdi
Copy link
Member Author

ge0rdi commented Feb 1, 2023

Not sure if it makes a functional difference, but the new help files should be mentioned in OpenShellTOC.hhc. It may be required for the side panel navigation

I'm not sure we need to show these pages in side panel.
Side panel contains More about skins and Custom Start Button sections already and one can find these tutorials there.

@ge0rdi
Copy link
Member Author

ge0rdi commented Feb 1, 2023

Though we can add those submenus in side panel if you think its worth.
This is how it would look like:
image

@vodek3
Copy link

vodek3 commented Feb 1, 2023

Not sure if it makes a functional difference, but the new help files should be mentioned in OpenShellTOC.hhc. It may be required for the side panel navigation

It's done in #1317 - 0885f19

@bonzibudd
Copy link
Member

Though we can add those submenus in side panel if you think its worth.

I think that would be the best option. It seems like it would be difficult to find a large page if just looking for a single link on another page.

@ge0rdi
Copy link
Member Author

ge0rdi commented Feb 3, 2023

I think that would be the best option. It seems like it would be difficult to find a large page if just looking for a single link on another page.

Oki, no problem.
I've pushed those changes.

@ge0rdi ge0rdi requested a review from bonzibudd February 3, 2023 08:05
@bonzibudd
Copy link
Member

Seems to be working well. There may be some small formatting things for the new help files but those can be addressed in the future.

bonzibudd
bonzibudd previously approved these changes Feb 7, 2023
@ge0rdi ge0rdi merged commit bcc76dd into master Feb 7, 2023
@ge0rdi ge0rdi deleted the localization-changes branch February 7, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants