Skip to content

Spec/updates #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 18, 2018
Merged

Spec/updates #84

merged 7 commits into from
May 18, 2018

Conversation

@david-driscoll
Copy link
Member

@david-driscoll david-driscoll commented May 7, 2018

Fixes #82, #83

Brings up to date with the latest lsp spec.
@tintoy
Copy link
Collaborator

tintoy commented May 7, 2018

Do we support multiple workspaces yet? That seems like a pretty big chunk of work and the API changes may be tricky to do in a backward-compatible opt-in manner...
@codecov
Copy link

codecov bot commented May 7, 2018 •
edited
Loading

Codecov Report

Merging #84 into master will decrease coverage by 1.72%.
The diff coverage is 35.97%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #84 +/- ## ========================================== - Coverage 69.04% 67.31% -1.73%  ========================================== Files 215 237 +22 Lines 2384 2524 +140 ========================================== + Hits 1646 1699 +53  - Misses 738 825 +87
Impacted Files Coverage Δ
...rc/Protocol/Client/RegisterCapabilityExtensions.cs 0% <ø> (ø) ⬆️
src/Protocol/Supports.cs 57.14% <ø> (ø)
...ization/Converters/BooleanNumberStringConverter.cs 86.66% <ø> (ø) ⬆️
...tocol/Server/Capabilities/TypeDefinitionOptions.cs 0% <0%> (ø)
...tocol/Server/Capabilities/ImplementationOptions.cs 0% <0%> (ø)
...tocol/Models/WorkspaceFolderRegistrationOptions.cs 0% <0%> (ø)
src/Protocol/Models/DocumentColorParams.cs 0% <0%> (ø)
src/Protocol/Models/ConfigurationParams.cs 0% <0%> (ø)
...c/Protocol/Workspace/WorkspaceFoldersExtensions.cs 0% <0%> (ø)
src/Protocol/Models/ConfigurationItem.cs 0% <0%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b3af2...bd6673c. Read the comment docs.
@david-driscoll
Copy link
Member Author

david-driscoll commented May 9, 2018

@tintoy this adds initial support for the workspaces models. Right now it will only advertise workspaces if you implement a workspace handler.
david-driscoll
david-driscoll commented May 18, 2018
View reviewed changes
src/Server/LanguageServer.cs
ColorProvider = ccp.GetStaticOptions(textDocumentCapabilities.ColorProvider).Get<IColorOptions, StaticColorOptions>(ColorOptions.Of),
};

if (_collection.ContainsHandler(typeof(IDidChangeWorkspaceFoldersHandler)))
Copy link
Member Author

@david-driscoll david-driscoll May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tintoy we can make changes here to help determine if we should support workspace folders, however it's up to the implementor if they support them or not.
@david-driscoll
Copy link
Member Author

david-driscoll commented May 18, 2018

Going to merge for now... to focus on the other related pull request. want to try and get both in this weekend, so I can update OmniSharp with it.
@david-driscoll david-driscoll merged commit 0074159 into master May 18, 2018
@david-driscoll david-driscoll deleted the spec/updates branch May 18, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@david-driscoll @tintoy