Updated receiver to handle null params slightly differently, and chan… #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ged how Request Routers router requests
Codecov Report
@@ Coverage Diff @@ ## master #62 +/- ## ========================================== + Coverage 69.98% 70.03% +0.04% ========================================== Files 211 211 Lines 2209 2199 -10 ========================================== - Hits 1546 1540 -6 + Misses 663 659 -4
Continue to review full report at Codecov.
|
tintoy added a commit to tintoy/msbuild-project-tools-server that referenced this pull request Jan 15, 2018
Fixes a bug (OmniSharp/csharp-language-server-protocol#60 / OmniSharp/csharp-language-server-protocol#62) where language server failed to terminate when VS Code sent it a shutdown request.
tintoy added a commit to tintoy/msbuild-project-tools-vscode that referenced this pull request Jan 15, 2018
Fixes a bug (OmniSharp/csharp-language-server-protocol#60 / OmniSharp/csharp-language-server-protocol#62) where language server failed to terminate when VS Code sent it a shutdown request.
tintoy added a commit to tintoy/msbuild-project-tools-server that referenced this pull request Jan 16, 2018
Turns out this brings its own problems to the table because now the server won't complete initialisation when launched from VSCode. This reverts commit 9e3a444. Relates to OmniSharp/csharp-language-server-protocol#60 / OmniSharp/csharp-language-server-protocol#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…ged how Request Routers router requests