Added check to allow non spec compliant consumers to send us null for… #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… params. When a null is given we won't error, instead we will just pretend we never got any params at all.
tintoy approved these changes Jan 10, 2018
Collaborator
tintoy left a comment
tintoy left a comment There was a problem hiding this comment.
Yep, looks good - keen to try it out :)
| | ||
| // Special case params such that if we get a null value (from a non spec compliant system) | ||
| // that we don't fall over and throw an error. | ||
| if (@params?.Type == JTokenType.Null) |
Collaborator
There was a problem hiding this comment.
Nice catch - I would have forgotten to do this bit :)
Member Author
There was a problem hiding this comment.
Yeah we don't want to try to deserialize the value.
Member Author
| gotta make sure linux is happy then I'll push out as a new version. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
… params. When a null is given we won't error, instead we will just pretend we never got any params at all.
cc @tintoy