Null reference types #330
Merged
Null reference types #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #330 +/- ## ========================================== - Coverage 75.41% 75.23% -0.18% ========================================== Files 443 556 +113 Lines 12790 13034 +244 Branches 1186 1190 +4 ========================================== + Hits 9645 9806 +161 - Misses 3145 3228 +83
Continue to review full report at Codecov.
|
bjorkstromm reviewed Aug 25, 2020
Member
bjorkstromm left a comment
bjorkstromm left a comment There was a problem hiding this comment.
It's too big to review in GH... I'll checkout and check it locally at some point,
LSP.sln.DotSettings Outdated
| <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=EnforceWhileStatementBraces/@EntryIndexedValue">WARNING</s:String> | ||
| <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=RemoveRedundantBraces/@EntryIndexedValue">WARNING</s:String> | ||
| <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnnecessaryWhitespace/@EntryIndexedValue">WARNING</s:String> | ||
| <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnnecessaryWhitespace/@EntryIndexedValue">DO_NOT_SHOW</s:String> |
Member
There was a problem hiding this comment.
What! You're trying to mess with my OCD?
Member Author
There was a problem hiding this comment.
lol... probably a mistake.
david-driscoll force-pushed the feature/nullability branch 2 times, most recently from 141c4b8 to 952c933 Compare david-driscoll force-pushed the feature/nullability branch from 952c933 to 5619bfa Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.