Updated latest version of the 0.16 spec #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bjorkstromm reviewed Jul 22, 2020
Member
bjorkstromm left a comment
bjorkstromm left a comment There was a problem hiding this comment.
Looks good. One question regarding rename or Trace -> TraceValue
…c methods together, so that if you need to support cases where the method has changed, you can now.
Codecov Report
@@ Coverage Diff @@ ## master #263 +/- ## ========================================== + Coverage 60.58% 60.93% +0.34% ========================================== Files 350 350 Lines 10240 10328 +88 Branches 1158 1167 +9 ========================================== + Hits 6204 6293 +89 - Misses 3665 3668 +3 + Partials 371 367 -4
Continue to review full report at Codecov.
|
david-driscoll commented Jul 23, 2020
sample/SampleServer/Program.cs Outdated
| .WithHandler<SemanticTokens>() | ||
| .WithHandler<SemanticTokensHandler>() | ||
| // Linking here because the spec changed but vscode is behind | ||
| .WithLink(TextDocumentNames.SemanticTokensFull, "textDocument/semanticTokens") |
Member Author
There was a problem hiding this comment.
@TylerLeonhardt this lets us fake out the vscode client for now, until it's updated to line up with the spec.
…owever watch for allocations
Collaborator
| yay! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.