Skip to content

allow hyphens in font family name #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2017
Merged

allow hyphens in font family name #90

merged 2 commits into from
May 12, 2017

Conversation

pukomuko
Copy link
Contributor

this fixes bug #89
@mikesamuel
Copy link
Contributor

Thanks for the PR. Sorry it's taken me so long to respond.

Does this allow font-family names like ---? If so, is that a valid family name?
@pukomuko
Copy link
Contributor Author

pukomuko commented Apr 3, 2017

It does not allow for '---' family name. I cannot tell if it is valid name. Probably not.
@mikesamuel mikesamuel merged commit 1f3b688 into OWASP:master May 12, 2017
@mikesamuel
Copy link
Contributor

Thanks for the patch. I'm going to add some tests to make sure there's no CDO/CDC ambiguity ( <!--, --> ) but it'll be in the next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@pukomuko @mikesamuel