Skip to content

Conversation

@mbehr1
Copy link
Contributor

@mbehr1 mbehr1 commented Jun 22, 2024

Added a usability workaround that provides the default macos lib archive path on macos.

@otavio otavio force-pushed the feat/feat_static_and_macos branch from 4e98af5 to c86da8a Compare June 24, 2024 14:09
On macos brew installs libarchive.pc file not into the default path. Manually setting the ENV before being able to use cargo ... or esp. vs code "test"/"debug" features is a pain. So adding this workaround.
@otavio otavio force-pushed the feat/feat_static_and_macos branch 5 times, most recently from c9a0aec to 7ee8642 Compare June 24, 2024 16:54
@otavio otavio force-pushed the feat/feat_static_and_macos branch 2 times, most recently from 47ffdc3 to 6afd609 Compare June 24, 2024 17:01
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio otavio force-pushed the feat/feat_static_and_macos branch from 6afd609 to f98db35 Compare June 24, 2024 17:17
@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9649605205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 84.826%

Totals Coverage Status
Change from base Build 9647214899: 1.0%
Covered Lines: 341
Relevant Lines: 402

💛 - Coveralls
@otavio otavio merged commit ca9c246 into OSSystems:master Jun 24, 2024
@mbehr1
Copy link
Contributor Author

mbehr1 commented Jun 25, 2024

@otavio thx for merging/fixing/improving so quickly! Appreciated!

@otavio
Copy link
Member

otavio commented Jun 25, 2024

No worries; are there other fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants