Don't bother logging small millisecond times in restore messages #8977
Description
In the log of the build for dotnet/runtime we have many lines like
Restore completed in 545.01 ms for C:\Users\danmose\.nuget\packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19617.1\tools\Tools.proj. Restore completed in 41.68 ms for C:\git\runtime\src\installer\pkg\packaging\pack-managed.proj. Restore completed in 41.68 ms for C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetAppHost\Microsoft.NETCore.DotNetAppHost.pkgproj. Restore completed in 56.98 ms for C:\git\runtime\src\installer\pkg\packaging\vs-insertion-packages.proj. Restore completed in 1.77 ms for C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetHostPolicy\Microsoft.NETCore.DotNetHostPolicy.pkgproj. Restore completed in 59 ms for C:\git\runtime\src\installer\corehost\build.proj. Restore completed in 63.74 ms for C:\git\runtime\src\installer\managed\Microsoft.DotNet.PlatformAbstractions\Microsoft.DotNet.PlatformAbstractions.csproj. Restore completed in 58.09 ms for C:\git\runtime\src\installer\managed\Microsoft.Extensions.DependencyModel\Microsoft.Extensions.DependencyModel.csproj. Restore completed in 59.85 ms for C:\git\runtime\src\installer\managed\Microsoft.NET.HostModel\Microsoft.NET.HostModel.csproj. Restore completed in 1.58 ms for C:\git\runtime\src\installer\pkg\projects\netcoreapp\pkg\Microsoft.NETCore.App.Host.pkgproj. Restore completed in 2.01 ms for C:\git\runtime\src\installer\pkg\projects\netcoreapp\pkg\legacy\Microsoft.NETCore.App.pkgproj. Restore completed in 1.73 ms for C:\git\runtime\src\installer\pkg\projects\netcoreapp\sfx\Microsoft.NETCore.App.Bundle.bundleproj. Restore completed in 1.56 ms for C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetHostResolver\Microsoft.NETCore.DotNetHostResolver.pkgproj. Restore completed in 1.51 ms for C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetHost\Microsoft.NETCore.DotNetHost.pkgproj. Restore completed in 1.59 ms for C:\git\runtime\src\installer\pkg\projects\netstandard\pkg\NETStandard.Library.Ref.pkgproj. Restore completed in 20.41 ms for C:\git\runtime\src\installer\pkg\projects\netcoreapp\pkg\Microsoft.NETCore.App.Runtime.pkgproj. ... I suspect there aren't any circumstances where anyone wants to know it took 1510 microseconds to restore Microsoft.NETCore.DotNetHost.pkgproj: it's just visual noise. How about just logging:
Restored C:\Users\danmose\.nuget\packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19617.1\tools\Tools.proj. Or, if it's important to log the time when it's "slow", we could log it if it's over, say, 500ms, eg:
Restored C:\Users\danmose\.nuget\packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19617.1\tools\Tools.proj (took 545ms) Restored C:\git\runtime\src\installer\pkg\packaging\pack-managed.proj. Restored C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetAppHost\Microsoft.NETCore.DotNetAppHost.pkgproj. Restored C:\git\runtime\src\installer\pkg\packaging\vs-insertion-packages.proj. Restored C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetHostPolicy\Microsoft.NETCore.DotNetHostPolicy.pkgproj. Restored C:\git\runtime\src\installer\corehost\build.proj. Restored C:\git\runtime\src\installer\managed\Microsoft.DotNet.PlatformAbstractions\Microsoft.DotNet.PlatformAbstractions.csproj. Restored C:\git\runtime\src\installer\managed\Microsoft.Extensions.DependencyModel\Microsoft.Extensions.DependencyModel.csproj. Restored C:\git\runtime\src\installer\managed\Microsoft.NET.HostModel\Microsoft.NET.HostModel.csproj. Restored C:\git\runtime\src\installer\pkg\projects\netcoreapp\pkg\Microsoft.NETCore.App.Host.pkgproj. Restored C:\git\runtime\src\installer\pkg\projects\netcoreapp\pkg\legacy\Microsoft.NETCore.App.pkgproj. Restored C:\git\runtime\src\installer\pkg\projects\netcoreapp\sfx\Microsoft.NETCore.App.Bundle.bundleproj. Restored C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetHostResolver\Microsoft.NETCore.DotNetHostResolver.pkgproj. Restored C:\git\runtime\src\installer\pkg\projects\Microsoft.NETCore.DotNetHost\Microsoft.NETCore.DotNetHost.pkgproj. Restored C:\git\runtime\src\installer\pkg\projects\netstandard\pkg\NETStandard.Library.Ref.pkgproj. Restored C:\git\runtime\src\installer\pkg\projects\netcoreapp\pkg\Microsoft.NETCore.App.Runtime.pkgproj. I'd be happy to offer a change.